Add Smoke Test for Tabs #718
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tracy-Walker
approved these changes
Aug 13, 2025
There was a problem hiding this comment.
I think we'll want to improve middle_click() to work in both the Chrome and Content contexts. I'll create a bug for that work. Otherwise this looks good. I'll ask to push this through the two random test failures.
|
@ben-c-at-moz, Please push this through. This PR touched BasePage class. Thus CI is running everything and experiencing random failures. The two tests failing in the latest commit did not fail in previous commit and all tests PASS on Mac. Per my review comment, we'll want to improve the middle_click() method added here. But I'll do that in another bug/patch. |
ben-c-at-moz
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant Links
Bugzilla: https://bugzilla.mozilla.org/show_bug.cgi?id=1976537
TestRail: 134455
Description of Code / Doc Changes
Leave a bullet-pointed list of changes you made.
Created a test to ensure that middle clicking or pressing control/command and clicking a hyperlink
will correctly create a new background tab. Selenium does not directly support
middle clicking so I used the pynput library to simulate middle clicking. The test
will dynamically determine the location of the hyperlink element so the mouse will correctly
over it before initiating a middle click.
Added control click and middle click functions to page_base.py
Process Changes Required
Mark the relevant boxes:
pipenv install)Screenshots or Explanations
If you need to explain your code, do it here.
Comments or Future Work
Do we need to start another PR soon to address something you saw while working on this?
Workflow Checklist
Thank you!